Attention is currently required from: laforge, neels.

View Change

2 comments:

• File include/osmocom/core/utils.h:

  • Patch Set #2, Line 288: #define OSMO_STRBUF_CHAR_COUNT(STRBUF) ((STRBUF).buf && (STRBUF).pos > (STRBUF).buf ? \

    I would really welcome some extra formatting (lines) and more parenthesis to make this readable at all, as well as having clear understanding of the operation priorities.

• File src/core/utils.c:

  • Patch Set #2, Line 1238: if (!sb->pos)

    how is it is possible that if n_chars were written to sb->pos, sb->pos is null? This makes no sense to me?

To view, visit change 35207. To unsubscribe, or for help writing mail filters, visit settings.