Attention is currently required from: fixeria, laforge, osmith, pespin.
pespin uploaded patch set #3 to this change.
The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder
logging: Support nonblocking-io for log target stderr & file, make it default
The nonblocking-io used to be the mode used until recently, where wq
only was used if the write buffer was full.
This is more performant that always waiting for poll() to write, plus
the fact that we write to system synchronously, hence seeing output
immediatelly or not losing it if program crashes.
Furthermore, It turns out using wq in multithreaded programs may cause
problems, so better switch back to using nonblocking-io by default.
Related: OS#6947
Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7
---
M include/osmocom/core/logging.h
M src/core/libosmocore.map
M src/core/logging_file.c
M src/vty/logging_vty.c
M tests/logging/logging_vty_test.vty
5 files changed, 96 insertions(+), 24 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/42088/3
To view, visit change 42088. To unsubscribe, or for help writing mail filters, visit settings.