Attention is currently required from: laforge, lynxis lazus.

pespin uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by lynxis lazus

ranap_msg_factory: Fix API documentation regarding ip param endianness

The param is clearly being expected as host-byte order because it
converts it when storing it into the sockaddr, which contains a net-byte
order.

Both users of these APIs, ie. osmo-sgsn and osmo-msc, actually end up
passing a host-byte order addr despite wrongly using htonl() instead of
ntohl(), but taking advantage of the fact that both functions do the
same:
* osmo-sgsn: sgsn_pdp_ctx_iu_rab_activate() does "htonl(pdp->lib->gsnru.v)",
  where "v" is stored as network-byte order.
* osmo-msc: ran_iu_make_rab_assignment() does "osmo_htonl(inet_addr(ac->cn_rtp->ip))",
  where clearly inet_addr returns a network-byte order.

Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2
---
M src/ranap_msg_factory.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/57/43257/2

To view, visit change 43257. To unsubscribe, or for help writing mail filters, visit settings.