Attention is currently required from: osmith, pespin.

View Change

1 comment:

• File src/host/trxcon/src/trx_if.c:

  • Patch Set #1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff);

    If the API takes care, why then sending it explicitly here?

    Not sure what you mean by "explicitly". `osmo_trx_ep` does not make any assumptions regarding POWERON/POWEROFF, so there's simply no implicit "send POWEROFF on close()" logic.

    `fi->state == TRX_ST_POWERON` here in `trx_fsm_cleanup_cb()` is actually an abnormal case. It can happen if the L1CTL peer does not shutdown trxcon properly (i.e. does not send `L1CTL_RESET_REQ`) before disconnecting. In this case we (the FSM) enqueue TRXC POWEROFF message, so that we do not leave the transceiver running.

To view, visit change 43828. To unsubscribe, or for help writing mail filters, visit settings.