Attention is currently required from: fixeria.

Patch set 1:Code-Review +2

View Change

1 comment:

• File contrib/jenkins.sh:

  • Patch Set #1, Line 90: $MAKE distcheck || cat-testlogs.sh

    I was about to write: the check wouldn't abort on error here unless you explicitly add the exit 1:

    ```suggestion

    if ! $MAKE distcheck; then
    	cat-testlogs.sh
    	exit 1

    fi```

    
    ... but cat-testlogs.sh already has "exit 1" so this is fine:
    https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/scripts/cat-testlogs.sh

To view, visit change 43530. To unsubscribe, or for help writing mail filters, visit settings.