Attention is currently required from: laforge, pespin.
3 comments:
File include/osmocom/mgcp/fmtp.h:
Patch Set #10, Line 1: #pragma once
libosmocore is too generic for mgcp specific stuff. […]
ok, will try that
File src/libosmo-mgcp-client/mgcp_client.c:
==
(somehow gerrit lost the right place for this. the == is below.)
File src/libosmo-mgcp-client/mgcp_client.c:
Patch Set #9, Line 1290: && (mgcp_msg->ptmap[i].codec == CODEC_AMR_8000_1
(fact: the problem with the "&&" at the start of the line instead of appending at the end of last on […]
- it's much more efficient to read the condition with operators at the start.
at the start, they are in a fixed position, and form a tree structure (akin to a file tree view) with the operators as the node bullets.
With operators at the end, the eye needs to scan around.
- the loss of indent happens only once per logical branch in the condition and is only 3 chars...
i would very much like to continue using this structuring in my conditions.
To view, visit change 34900. To unsubscribe, or for help writing mail filters, visit settings.