Attention is currently required from: neels.
View Change
1 comment:
Patchset:
Patch Set #2:
two reasons: […]
Doesn't look valid points to me.
- doc/reminder: that's what UserManual is for.
- having to set up cap_net_admin all the time: You also need to run it every time and you don't add a script run_upf.sh for that. This should be set in your own env (osmo-dev?) IMHO, not here, specially since it's basically a oneliner.
I really don't see the point in having this in, let's see what other think.
To view, visit change 28311. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: If31c304e2602d3c37d5d8a5a2705417b2fc4686c
Gerrit-Change-Number: 28311
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Jul 2022 16:10:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment