Attention is currently required from: fixeria.

View Change

1 comment:

• File include/osmocom/codec/codec.h:

  • Patch Set #1, Line 85: etsi_sid_class

    I know it's not strictly followed here in this file, but generally it's a good idea to prepend `osmo […]

    Here I used etsi_ and ETSI_ naming prefixes for the enum and its items, as opposed to osmo_ and OSMO_, to denote the fact that these constants are rigidly defined by ETSI rather than us. To my perhaps naive intuitive mind, if something is named osmo_xxx, then the implication is that the "thing" is Osmo-defined and hence future Osmocom developers are free to change and extend the thing being defined - but the constants in the present case *cannot* be changed by us, they appear exactly with these numeric values in external interfaces such as TRAU-UL frame bits C13 & C14 and a_dd[0] bits [4:3] in TI DSPs.

To view, visit change 32183. To unsubscribe, or for help writing mail filters, visit settings.