Attention is currently required from: msuraev.
View Change
1 comment:
File src/stream.c:
Patch Set #2, Line 1334: ret
Somehow I missed this. According to man: "Upon successful completion, send() shall return the number of bytes sent. Otherwise, -1 shall be returned and errno set to indicate the error." So here you should do strerror(errno) instead.
To view, visit change 29082. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f
Gerrit-Change-Number: 29082
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: msuraev <msuraev@sysmocom.de>
Gerrit-Comment-Date: Sun, 21 Aug 2022 13:13:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment