Attention is currently required from: neels, pespin.

View Change

3 comments:

• File src/osmo-hnbgw/hnbgw_hnbap.c:

  • Patch Set #6, Line 571: hnb_persistent_connected(ctx->persistent);

    It really depends on the specific event you want to track here. […]

    I agree pespin's wording is more clear.

• File src/osmo-hnbgw/hnbgw_vty.c:

  • Patch Set #12, Line 885: "nft-kpi [TABLE_NAME]",

    shouldn't this be in some kind of #ifdef block to suppress offering those vty commands in case the program was not compiled with nftables support?

• File src/osmo-hnbgw/nft_kpi.c:

  • Patch Set #9, Line 994: nft_kpi_get_counters_schedule();

    I really think we want to at least do as I described, which is really quick to implement (adding one […]

    I agree with neels that his approach implements what we discussed (for the reasons we discussed and he stated). Yes, it's not ideal from the user point of view, but let's not be perfect at the cost of dragging this another week.

To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.