Attention is currently required from: fixeria, laforge, neels.
Patch set 2:Code-Review +1
View Change
1 comment:
File src/libmsc/msc_a.c:
Patch Set #2, Line 192: osmo_timer_schedule(&msc_a->lu_delay_timer, Tval, 0);
> are you sure the object cannot be destroyed in any way while the timer is set? […]
Yes that's for sure true during the usual operation. I'm just raising the point in case there's some other "tear down everything immediatelly" code path I'm not aware of. Not saying it's there, just pointing out in case there's something like that :)
To view, visit change 36760. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2024 14:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment