pespin submitted this change.

View Change

Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified
ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0

I originally copied the ASN1 files from https://forge.etsi.org/rep/int/5g-core/ngap.git
directory ttcn/LibNGAP/lib/asn1, commit fa43d01e202379a969e991a9454d9c6c6930b5b5.

Apparently one file contained a deviation from the 3GPP content and it
was also fixed in ngap.git in 47e7239dd80f2f12a4cbcdd7977ca0a32356f3be.

I found out this problem when trying to use this ASN1 file to generate
new libfftranscode, which then failed to properly decode
DownlinkNASTransport due to the deviation.

Change-Id: I7d127998ea162a392f3381ebb1d198ad3c783a56
---
M library/ngap/NGAP_PDU_Descriptions.asn
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/library/ngap/NGAP_PDU_Descriptions.asn b/library/ngap/NGAP_PDU_Descriptions.asn
index d8dbd98..dcf4704 100644
--- a/library/ngap/NGAP_PDU_Descriptions.asn
+++ b/library/ngap/NGAP_PDU_Descriptions.asn
@@ -266,7 +266,7 @@
InitiatingMessage ::= SEQUENCE {
procedureCode NGAP-ELEMENTARY-PROCEDURE.&procedureCode ({NGAP-ELEMENTARY-PROCEDURES}),
criticality NGAP-ELEMENTARY-PROCEDURE.&criticality ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode}),
- value NGAP-ELEMENTARY-PROCEDURE.&InitiatingMessage ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode}) OPTIONAL
+ value NGAP-ELEMENTARY-PROCEDURE.&InitiatingMessage ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode})
}

SuccessfulOutcome ::= SEQUENCE {

To view, visit change 40729. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7d127998ea162a392f3381ebb1d198ad3c783a56
Gerrit-Change-Number: 40729
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>