Attention is currently required from: jolly.

Patch set 8:Code-Review +1

View Change

3 comments:

• File src/core/osmo_io_internal.h:

  • Patch Set #8, Line 113: uint8_t read_sqes;

    num_read_sqes?

  • Patch Set #8, Line 117: uint8_t read_count;

    reads_in_transit? reads_in_progress?

• File src/core/osmo_io_uring.c:

  • Patch Set #8, Line 152: msg = iofd_msgb_alloc(iofd);

    I think having each loop iteration in a separate function should make this easier to read and maintain.

    That also means this patch suddenly has half of modified lines.

To view, visit change 40494. To unsubscribe, or for help writing mail filters, visit settings.