Attention is currently required from: fixeria.

View Change

1 comment:

• File src/shared/l1gprs.c:

  • Patch Set #1, Line 138: "%s(): " LOG_TBF_FMT " not found\n",

    Following this logic using macros in general makes the code complicated because "you're not sure wha […]

    You don't need to follow that logic because that's not what I'm saying. If you have LOG_TBF_FMT and LOG_TBF_ARGS(tbf) used at the same time, it's clear they both refer each other and they match. At the moment you start using LOG_TBF_FMT without its counterpart (a macro passing all its params) it misses its point.
    But anyway, not important, do as you wish.

To view, visit change 31969. To unsubscribe, or for help writing mail filters, visit settings.