fixeria has uploaded this change for review.

View Change

l1ctl_proto.h: explicitly assign message type values

Explicit is better than implicit.  Having the message type values
assigned explicitly allows rearranging messages in the middle
without affecting the message type values following them.

Change-Id: I1ec32289a24c5704ea0676b508cb12ee0b4890d7
---
M include/l1ctl_proto.h
1 file changed, 37 insertions(+), 40 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/31/31331/1

diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h
index a15f905..7e415e9 100644
--- a/include/l1ctl_proto.h
+++ b/include/l1ctl_proto.h
@@ -21,48 +21,45 @@
 #define __L1CTL_PROTO_H__
 
 enum {
-	_L1CTL_NONE		= 0,
-	L1CTL_FBSB_REQ,
-	L1CTL_FBSB_CONF,
-	L1CTL_DATA_IND,
-	L1CTL_RACH_REQ,
-	L1CTL_DM_EST_REQ,
-	L1CTL_DATA_REQ,
-	L1CTL_RESET_IND,
-	L1CTL_PM_REQ,		/* power measurement */
-	L1CTL_PM_CONF,		/* power measurement */
-	L1CTL_ECHO_REQ,
-	L1CTL_ECHO_CONF,
-	L1CTL_RACH_CONF,
-	L1CTL_RESET_REQ,
-	L1CTL_RESET_CONF,
-	L1CTL_DATA_CONF,
-	L1CTL_CCCH_MODE_REQ,
-	L1CTL_CCCH_MODE_CONF,
-	L1CTL_DM_REL_REQ,
-	L1CTL_PARAM_REQ,
-	L1CTL_DM_FREQ_REQ,
-	L1CTL_CRYPTO_REQ,
-	L1CTL_SIM_REQ,
-	L1CTL_SIM_CONF,
-	L1CTL_TCH_MODE_REQ,
-	L1CTL_TCH_MODE_CONF,
-	L1CTL_NEIGH_PM_REQ,
-	L1CTL_NEIGH_PM_IND,
-	L1CTL_TRAFFIC_REQ,
-	L1CTL_TRAFFIC_CONF,
-	L1CTL_TRAFFIC_IND,
-	L1CTL_BURST_IND,
-
+	_L1CTL_NONE			= 0x00,
+	L1CTL_FBSB_REQ			= 0x01,
+	L1CTL_FBSB_CONF			= 0x02,
+	L1CTL_DATA_IND			= 0x03,
+	L1CTL_RACH_REQ			= 0x04,
+	L1CTL_DM_EST_REQ		= 0x05,
+	L1CTL_DATA_REQ			= 0x06,
+	L1CTL_RESET_IND			= 0x07,
+	L1CTL_PM_REQ			= 0x08, /* power measurement */
+	L1CTL_PM_CONF			= 0x09, /* power measurement */
+	L1CTL_ECHO_REQ			= 0x0a,
+	L1CTL_ECHO_CONF			= 0x0b,
+	L1CTL_RACH_CONF			= 0x0c,
+	L1CTL_RESET_REQ			= 0x0d,
+	L1CTL_RESET_CONF		= 0x0e,
+	L1CTL_DATA_CONF			= 0x0f,
+	L1CTL_CCCH_MODE_REQ		= 0x10,
+	L1CTL_CCCH_MODE_CONF		= 0x11,
+	L1CTL_DM_REL_REQ		= 0x12,
+	L1CTL_PARAM_REQ			= 0x13,
+	L1CTL_DM_FREQ_REQ		= 0x14,
+	L1CTL_CRYPTO_REQ		= 0x15,
+	L1CTL_SIM_REQ			= 0x16,
+	L1CTL_SIM_CONF			= 0x17,
+	L1CTL_TCH_MODE_REQ		= 0x18,
+	L1CTL_TCH_MODE_CONF		= 0x19,
+	L1CTL_NEIGH_PM_REQ		= 0x1a,
+	L1CTL_NEIGH_PM_IND		= 0x1b,
+	L1CTL_TRAFFIC_REQ		= 0x1c,
+	L1CTL_TRAFFIC_CONF		= 0x1d,
+	L1CTL_TRAFFIC_IND		= 0x1e,
+	L1CTL_BURST_IND			= 0x1f,
 	/* configure TBF for uplink/downlink */
-	L1CTL_TBF_CFG_REQ,
-	L1CTL_TBF_CFG_CONF,
-
-	L1CTL_DATA_TBF_REQ,
-	L1CTL_DATA_TBF_CONF,
-
+	L1CTL_TBF_CFG_REQ		= 0x20,
+	L1CTL_TBF_CFG_CONF		= 0x21,
+	L1CTL_DATA_TBF_REQ		= 0x22,
+	L1CTL_DATA_TBF_CONF		= 0x23,
 	/* Extended (11-bit) RACH (see 3GPP TS 05.02, section 5.2.7) */
-	L1CTL_EXT_RACH_REQ,
+	L1CTL_EXT_RACH_REQ		= 0x24,
 };
 
 enum ccch_mode {

To view, visit change 31331. To unsubscribe, or for help writing mail filters, visit settings.