laforge submitted this change.

View Change


Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved falconia: Looks good to me, but someone else must approve laforge: Looks good to me, approved
Fix incorrect order of params passed to logging macro

Stops log lines like:
'DOML unknown 0x239616 (bts=0,trx=0,ts=1,ss=0) [....]'

Change-Id: Ie1ad41210280ae5dbe693de6bdc4378ff34621b7
---
M src/osmo-bts-sysmo/tch.c
1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c
index 0109771..a0d1cf8 100644
--- a/src/osmo-bts-sysmo/tch.c
+++ b/src/osmo-bts-sysmo/tch.c
@@ -635,7 +635,7 @@
if (is_recv_only(lchan->abis_ip.speech_mode))
return -EAGAIN;

- LOGPLCFN(lchan, DL1P, LOGL_DEBUG, data_ind->u32Fn, "chan_nr %d Rx FACCH\n", chan_nr);
+ LOGPLCFN(lchan, data_ind->u32Fn, DL1P, LOGL_DEBUG, "chan_nr %d Rx FACCH\n", chan_nr);
/* Push empty payload to upper layers */
rmsg = msgb_alloc_headroom(256, 128, "L1P-to-RTP");
return add_l1sap_header(trx, rmsg, lchan, chan_nr, data_ind->u32Fn,

To view, visit change 34085. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie1ad41210280ae5dbe693de6bdc4378ff34621b7
Gerrit-Change-Number: 34085
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith@rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged