Attention is currently required from: fixeria.
Patch set 2:Code-Review +1
View Change
1 comment:
File Makefile:
Patch Set #2, Line 36: install -m 0644 -T config/sys.config $(DESTDIR)$(CONFDIR)/osmo-s1gw.config
As in the other patch, I suggest using install -Dm644 etc. instead, -D to let it create the directory
To view, visit change 37728. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278
Gerrit-Change-Number: 37728
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 07:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes