fixeria submitted this change.

View Change



3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified
sms: fix flags_construct in SMS_DELIVER

* field `tp_rp` appears at bit positions 7 and 5
** bit 7 should be `tp_rp` (Reply Path)
** bit 5 should be `tp_sri` (Status Report Indication)
* field `tp_lp` is completely missing
** should be at bit position 3

Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8
---
M pySim/sms.py
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/pySim/sms.py b/pySim/sms.py
index aefc874..62601b0 100644
--- a/pySim/sms.py
+++ b/pySim/sms.py
@@ -169,8 +169,14 @@

class SMS_DELIVER(SMS_TPDU):
"""Representation of a SMS-DELIVER T-PDU. This is the Network to MS/UE (downlink) direction."""
- flags_construct = BitStruct('tp_rp'/Flag, 'tp_udhi'/Flag, 'tp_rp'/Flag, 'tp_sri'/Flag,
- Padding(1), 'tp_mms'/Flag, 'tp_mti'/BitsInteger(2))
+ flags_construct = BitStruct('tp_rp'/Flag,
+ 'tp_udhi'/Flag,
+ 'tp_sri'/Flag,
+ Padding(1),
+ 'tp_lp'/Flag,
+ 'tp_mms'/Flag,
+ 'tp_mti'/BitsInteger(2))
+
def __init__(self, **kwargs):
kwargs['tp_mti'] = 0
super().__init__(**kwargs)

To view, visit change 42381. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8
Gerrit-Change-Number: 42381
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>