Attention is currently required from: Hoernchen, laforge, fixeria.
Patch set 3:Code-Review -1
View Change
2 comments:
Patchset:
Patch Set #3:
the check doesn't seem to work in a fresh clone:
$ git clone https://gitea.osmocom.org/cellular-infrastructure/osmo-trx/
$ cd osmo-trx
$ git fetch https://gerrit.osmocom.org/osmo-trx refs/changes/95/30795/3 && git checkout FETCH_HEAD
$ autoreconf -fi
$ ./configure # does NOT complain
File configure.ac:
Patch Set #3, Line 218: AC_MSG_ERROR([$LIBTRXCON_DIR does not exist])
give a hint here, what git command the user should run to fetch the submodule?
To view, visit change 30795. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I06456c2087e160032f5bf8b36304477390f117d0
Gerrit-Change-Number: 30795
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Feb 2023 08:52:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment