Attention is currently required from: arehbein, pespin, daniel.

Patch set 4:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    Ok then I'll prepare a patch removing osmo_iofd_write_{en,dis}able

    Those were only ever intended as public API for the user. Internally the txqueue will take care of dis-/enabling the writes.

    great. Then let's not introduce API where we don't have a clear use case for. IF it should ever be needed, we can introduce it then.

    The next question then is whether read_{en,dis}able is actually needed in osmo_io.

    I'd treat it like above, i.e. not introduce it now if we have no user in our existing codebase, and introduce it _if_ ever needed later.

To view, visit change 33084. To unsubscribe, or for help writing mail filters, visit settings.