Attention is currently required from: fixeria, osmith.
7 comments:
File src/sccp2sua.c:
Patch Set #3, Line 455: one byte
you say "one", but actually allocating two?
Ack
Patch Set #3, Line 466: LSB first
use `osmo_store16le()` here?
Ack
Patch Set #3, Line 554: ptr_addr + 1 + ptr_value + 2
Seeing more and more pointer arithmetic, I am wondering if we could have a packed struct with a unio […]
There's a lot of pointer arithmetic because well, the protocol structures work with relative pointer, so pointer arithmetic is needed ;)
Moreover, the offsets change depending on the message and/or attribute, so yes, it's a mess no matter how you implement it.
Patch Set #3, Line 557: LSB first
use `osmo_load16le()` here?
Ack
Patch Set #3, Line 809: ptr_opt + (ptr_opt_is_long ? 1 : 0) > msg->tail
btw, what if the value equals `msg->tail`? I am not 100% sure, but it looks like you need to make s […]
Ack
but you say 255 in the comment above?
That was this way from Harald initial WIP commit. I'll increase it to 255, but anyway all this needs to be further improved to be 100% correct, because according to several parts of spec iirc there's a table saying the maximum size for DATA is lower, but it's all bit more complex, so we can work on that as a follow-up.
File tests/xua/xua_test.c:
`>>`
Ack
To view, visit change 34467. To unsubscribe, or for help writing mail filters, visit settings.