View Change

4 comments:

• File include/osmocom/mgcp/mgcp_iuup.h:

  • Patch Set #2, Line 1: /

    comment wrong?

• File src/libosmo-mgcp/mgcp_iuup.c:

  • Patch Set #2, Line 28: static struct osmo_iuup_rnl_config def_configure_req = {

    shouldn't the default be 'const' to avoid it accidentailly being modified/written to?

  • Patch Set #2, Line 229: /

    should this code be present at all if we're not yet doing the right thing? Or #if0 it ?

  • Patch Set #2, Line 529: /

    same as the comment above. Do we really want to introduce knonw-broken/insufficient code for the AMR<->IuUP case? Why not introduce just the IuUP<->IuUP case in one patch and then merge the AMR<->IuUP only once it's ready?

To view, visit change 26823. To unsubscribe, or for help writing mail filters, visit settings.