Attention is currently required from: fixeria, pespin.

Patch set 2:Code-Review +1

View Change

3 comments:

• File 5gc/open5gs/open5gs-amf.yaml:

  • Patch Set #2, Line 58: ################################################################################

    maybe worth removing all these comments and linking to the original config for reference instead, similar to https://gerrit.osmocom.org/c/docker-playground/+/35103? this makes it easier to read the file, and makes future diffs related to upstream config changes smaller (otherwise diffs need to include all the commented out stuff too, or they never get updated and become stale)

• File 5gc/regen_makefile.sh:

  • Patch Set #2, Line 6: # *.c

    remove these commented out lines?

• File Makefile:

  • Patch Set #1, Line 63: PARALLEL_MAKE ?= -j4

    unrelated change

    Done

To view, visit change 40367. To unsubscribe, or for help writing mail filters, visit settings.