laforge submitted this change.

View Change


Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
ts_102_221: Remove CardProfileUICCSIM

This profile has always been a hack/work-around for the situation that
a classic GSM SIM is not a UICC, and we didn't yet have the concept of
CardProfileAddons yet, so there was no way to probe and add something
to an UICC which was not an application with its own AID/ADF.

Since now we have CardProfileAddons (including one for GSM SIM),
and pySim-trace (the other user of CardProfileUICCSIM) has also switched
over to using CardProfileUICC + addons, we can remove this work-around.

Change-Id: I45cec68d72f2003123da4c3f86ed6a5a90988bd8
---
M pySim/ts_102_221.py
1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py
index df8b842..ac0dc84 100644
--- a/pySim/ts_102_221.py
+++ b/pySim/ts_102_221.py
@@ -886,21 +886,3 @@
of the card is required between SUSPEND and RESUME, and only very few non-RESUME
commands are permitted between SUSPEND and RESUME. See TS 102 221 Section 11.1.22."""
self._cmd.card._scc.resume_uicc(opts.token)
-
-
-class CardProfileUICCSIM(CardProfileUICC):
- """Same as above, but including 2G SIM support"""
-
- ORDER = 0
-
- def __init__(self):
- super().__init__('UICC-SIM')
-
- # Add GSM specific files
- self.files_in_mf.append(DF_TELECOM())
- self.files_in_mf.append(DF_GSM())
-
- @staticmethod
- def match_with_card(scc: SimCardCommands) -> bool:
- # don't ever select this profile, we only use this from pySim-trace
- return False

To view, visit change 33724. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I45cec68d72f2003123da4c3f86ed6a5a90988bd8
Gerrit-Change-Number: 33724
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged