Attention is currently required from: laforge, daniel, lynxis lazus.
4 comments:
File src/gb/gprs_ns2_udp.c:
Patch Set #4, Line 183: struct osmo_sockaddr *saddr)
wrong indentation
Done
Patch Set #4, Line 225: static void handle_nsip_sendmsg(struct osmo_io_fd *iofd, int res, struct msgb *msg)
if this is not needed, then pass a NULL pointer instead of this function?
Answering myself here: the library code unconditionally calls the callback function, because the app is expected to want to have a callback set to be able to check the return code of the write operation done by the library (available in "res" param here).
Patch Set #4, Line 272: .sendmsg_cb = &handle_nsip_sendmsg,
= NULL
See my other comment.
File src/gb/gprs_ns2_udp.c:
if (priv->iofd)
osmo_iofd_free(priv->iofd);
ACK, in the new patchset osmo_iofd_free() can handle a call with NULL.
I'm adding this NULL check myself in the new version of the other patch I'm submitting now.
To view, visit change 30936. To unsubscribe, or for help writing mail filters, visit settings.