laforge submitted this change.

View Change


Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve tnt: Looks good to me, but someone else must approve laforge: Looks good to me, approved
octoi: Fix missing check of osmo_fsm_register() return value

Fixes: CID#307511: Unchecked return value (CHECKED_RETURN)
Change-Id: Ia474a6c078f1aec3d04be494a888ffe87b199f5a
---
M src/octoi/octoi.c
1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/octoi/octoi.c b/src/octoi/octoi.c
index 6e4b8f9..1c0a6e7 100644
--- a/src/octoi/octoi.c
+++ b/src/octoi/octoi.c
@@ -75,8 +75,8 @@
{
OSMO_ASSERT(!g_octoi);

- osmo_fsm_register(&octoi_server_fsm);
- osmo_fsm_register(&octoi_client_fsm);
+ OSMO_ASSERT(osmo_fsm_register(&octoi_server_fsm) == 0);
+ OSMO_ASSERT(osmo_fsm_register(&octoi_client_fsm) == 0);

g_octoi = talloc_zero(ctx, struct octoi_daemon);
OSMO_ASSERT(g_octoi);

To view, visit change 33784. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ia474a6c078f1aec3d04be494a888ffe87b199f5a
Gerrit-Change-Number: 33784
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: tnt <tnt@246tNt.com>
Gerrit-MessageType: merged