Attention is currently required from: pespin, msuraev.

View Change

3 comments:

• File src/rlcmac/rlcmac.c:

  • Patch Set #5, Line 278: OSMO_ASSERT(bv);

    I think so far common practice was to log memory allocation errors and shutdown gracefully. […]

    when mem alloc fails, logging cannot possibly work. we do in fact assert on alloc success very often. i agree with this assert.

  • Patch Set #5, Line 291: LOGRLCMAC(LOGL_NOTICE, "TODO: handle decoded dl ctrl block!\n");

    hmm, a TODO in the logs? maybe a #warning pragma instead?

• File src/rlcmac/tbf_dl.c:

  • Patch Set #5, Line 39: // goto err_tbf_destruct;

    i can understand that some code will come in only later, but you do add an awful lot of these temporarily commented things. Seems that a lot of them will end up surviving eternally and should rather be dropped from patches being merged; let's not let this become a habit, who will tidy up all of them?

To view, visit change 31286. To unsubscribe, or for help writing mail filters, visit settings.