Attention is currently required from: pespin.

View Change

3 comments:

• File include/osmocom/bsc/gsm_data.h:

  • Patch Set #4, Line 49: * We can't exactly know delta, so we ignore it */

    That we don't know delta it doesn't mean we can ignore it. […]

    I thought it might be possible to have a better estimate for delta by estimating the transmission time for HANDOVER FAILURE on the primary signaling link (CBCH?) and adding a small margin to account for processing.
    I think I found a bitrate in some spec, but somehow I couldn't find IE and hence message sizes (e.g. for Reject/Ignore IE) in text search of the respective spec.

    I'll put 1000 ms for now.

• File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

  • Patch Set #4, Line 95: msgb_tv_put(msgb, NM_ATT_NY1, osmo_tdef_get(bts->network->T_defs, -3105, OSMO_TDEF_CUSTOM, GSM_NY1_DEFAULT));

    it's a bit weird that you are introducing the osmo_tdef in this commit but you are still using GSM_N […]

    Done

• File src/osmo-bsc/net_init.c:

  • Patch Set #4, Line 78: .desc = "Max. repetitions for rerunning T3105/resending physical information (ny1)" },

    What about: […]

    Done

To view, visit change 30539. To unsubscribe, or for help writing mail filters, visit settings.