Attention is currently required from: Hoernchen, laforge.
6 comments:
Patchset:
Agree with Harald regarding common prefix. Also a bit more code documentaton (add more comments) would really help understanding the different pieces for people looking at the logging code.
File src/logging.c:
Patch Set #6, Line 107: memset(tmp_level, 100, osmo_log_info->num_cat);
It would be great to have this 100 and 99 which I see used below defined with a macro, holding a descriptive name of what it is.
Patch Set #6, Line 134: struct log_category tmp = { 99, 0 };
using { .field_a = 99, .field_b = 0} would certainly help here udnerstanding how are you filling this.
Patch Set #6, Line 145: log_level_lookup_cache[mapped_subsys] = tmp.enabled ? tmp.loglevel : 99;
Please put this 99 in a define. Also some comment explaining what this function implementation does would be nice.
Patch Set #6, Line 156: return (level < log_level_lookup_cache[mapped_subsys]) ? false : true;
"return (log_level_lookup_cache[mapped_subsys] >= level)" seems a lot shorter :)
File tests/bitgen/bitgen_test.c:
unrelated changes?
Ack
To view, visit change 30633. To unsubscribe, or for help writing mail filters, visit settings.