Attention is currently required from: dexter.

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_codec.c:

  • Patch Set #2, Line 440: conn->end.codec = mgcp_codec_find_same(conn, found_same_codec_opposite);

    The problem is that it is not possible to assign codec_conn_dst to conn_src->end. […]

    Ah I see what you mean, you are looking the codec in each conn list.
    Now the question I have is: why do we have codec structs holding the same data duplicated (allocated several times) for each connection?
    Wouldn't it make more sense to have them defined in 1 global place and then have a pointer to that global struct here in all conns?
    I'm not saying it has to be done in this commit, just pointing out some possibilities for improvement.

To view, visit change 32218. To unsubscribe, or for help writing mail filters, visit settings.