osmith submitted this change.

View Change

Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved
testenv: no python trace for setup script failures

Do not print a python trace when a setup script fails, usually it is
unrelated and just clutters the output.

Change-Id: Icbec52befa268547906fdbe9b52bdbc9e94722e6
---
M _testenv/testenv/daemons.py
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/_testenv/testenv/daemons.py b/_testenv/testenv/daemons.py
index da8248e..d4804d0 100644
--- a/_testenv/testenv/daemons.py
+++ b/_testenv/testenv/daemons.py
@@ -75,7 +75,8 @@
if "setup" in section_data:
setup = section_data["setup"]
logging.info(f"Running {section} setup script")
- testenv.cmd.run(setup, cwd=cwd)
+ if testenv.cmd.run(setup, cwd=cwd, check=False).returncode:
+ raise testenv.NoTraceException(f"{section}: setup script failed")


def kill_process_tree(pid, ppids):

To view, visit change 40310. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icbec52befa268547906fdbe9b52bdbc9e94722e6
Gerrit-Change-Number: 40310
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>