Attention is currently required from: pespin, msuraev.

Patch set 7:Code-Review -1

View Change

1 comment:

• File src/gsm/lapd_core.c:

  • Patch Set #7, Line 1750: msg_to_tx_hist0

    I don't like this. Why not pass a struct lapd_history pointer (be it &dl->tx_hist[h] or &dl->tx_hist[0]) directly to msg_to_tx_hist()? You're not accessing any other fields in dl anyway, AFAICS.

To view, visit change 30244. To unsubscribe, or for help writing mail filters, visit settings.