Attention is currently required from: osmith, laforge, pespin, fixeria.

View Change

2 comments:

• File src/osmo-bsc-nat/bssap_conn.c:

  • Patch Set #4, Line 47: uint8_t tag = tag_order[i];

    above we traverse the TLV structure once to store tlv_parsed entries.
    tlv_parsed entries are good for "random access", find a specific IE.
    Then we traverse the TLV again to store the tags in their order,
    caching in an array. Then we iterate the array again, which is sort
    of identical to traversing the TLV data itself.

    it seems to me that it makes more sense to not use tlv_parse() at all,
    but only do tlv_parse_one() and tlv_encode_one() in this loop.
    Then we don't need to use a random-access API for sequential access.

    Hence not needing new libosmocore API.

    I guess this doesn't really affect performance in a noticeable way,
    making it a bikeshed of sorts?

• File src/osmo-bsc-nat/subscr_conn_fsm.c:

  • Patch Set #2, Line 351: ,

    Neels invented this, but I like how it's diff friendly :)

    exactly, and it's also editing friendly

To view, visit change 27712. To unsubscribe, or for help writing mail filters, visit settings.