dexter has uploaded this change for review.

View Change

es10b_add_init_eim: improve log output

When the IoT eUICC emulation is active, the AddInitialEim has to
complete the eIM configuration before storing it. The completion
process assignes values to fields that are normally populated by
the eUICC.

Let's print a log line to make the user aware that this process
happens, so that there is no confusion about the completed eIM
configuration that is printed in the log lines after. Let's also
add another comment that explains what the completion is about.

Related: SYS#8287
Change-Id: Ife69835b378ae67c021bd1ad7dddd9f7259ebc47
---
M src/ipa/libipa/es10b_add_init_eim.c
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/35/43935/1
diff --git a/src/ipa/libipa/es10b_add_init_eim.c b/src/ipa/libipa/es10b_add_init_eim.c
index 2efa02d..a63cc22 100644
--- a/src/ipa/libipa/es10b_add_init_eim.c
+++ b/src/ipa/libipa/es10b_add_init_eim.c
@@ -130,10 +130,17 @@

struct AddInitialEimRequest *complete_eim_cfg_list(struct ipa_context *ctx, const struct AddInitialEimRequest *req)
{
+ /* The eIM configuration that is supplied with an AddInitialEimRequest is typically only a template and may
+ * lack certain values, which are normally computed by the eUICC (e.g. the associationToken). This function
+ * goes through all eIM configurations in the supplied AddInitialEimRequest and completes them. (This function
+ * must only be called from the IoT eUICC emulation code paths. It has no relevance for native IoT eUICCs) */
+
struct AddInitialEimRequest *req_dup;
unsigned int i;
int rc;

+ IPA_LOGP_ES10X("AddInitialEim", LINFO, "IoT eUICC emulation active, completing eIM configuration...\n");
+
req_dup = ipa_asn1c_dup(&asn_DEF_AddInitialEimRequest, req);

for (i = 0; i < req_dup->eimConfigurationDataList.list.count; i++) {

To view, visit change 43935. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ife69835b378ae67c021bd1ad7dddd9f7259ebc47
Gerrit-Change-Number: 43935
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier@sysmocom.de>