Attention is currently required from: jolly.

View Change

1 comment:

• File src/osmo-bsc/osmo_bsc_bssap.c:

  • Patch Set #2, Line 744: static int select_codecs(struct assignment_request *req, const struct gsm0808_channel_type *ct,

    bssmap_handle_ass_req_ct_speech() is called by vgcs_fsm.c. […]

    Can you point me to where is this function newly used? (I guess it's some other patch?)

    Also, the commit message is misleading. You are not simply making the function public, you are changing the logic and params also imho.

    Finally, to make the code paths easier, maybe avoid passing NULL in the only caller so far, and pass conn_get_bts() as a param there.

To view, visit change 33603. To unsubscribe, or for help writing mail filters, visit settings.