Attention is currently required from: fixeria, pespin.

Patch set 5:Code-Review -1

View Change

1 comment:

• File src/rtp.c:

  • Patch Set #4, Line 151: if (payload_len < 0) {

    This is no longer possible according to checks above. […]

    ah no, we cannot drop this, but also there is a mistake in patch set 1, because:

    payload_len can still be zero.
    If we want to read a padding length octet from the end, payload_len must be >= 1.
    So we need a check here, but it should be
      
        if (payload_len < 1)

    instead of 0.

To view, visit change 37992. To unsubscribe, or for help writing mail filters, visit settings.