Attention is currently required from: fixeria, pespin.
Patch set 1:Code-Review -1
3 comments:
Patchset:
this is the kind of issue where a clear-cut unit test showing the bug should be introduced first, and then the bug should be fixed in a follow-up commit, demonstrating that the unit test now passes.
I don't see immediately how his commit fixes anything - all it does is to return error values to the caller and log something, but it's not immediately obvious how an alternative encoding is chosen.
File src/osmo-bsc/system_information.c:
&& bts->c0->arfcn >= 1 && bts->c0->arfcn <= 124)
pgsm = true;
isn't this the true bug? PGSM is primary GSM, and not E-GSM 900. So the pgsm flag should never be set in a situation where E-GSM channels are used. Maybe we should not just check for c0->arfcn but iterate over all channels and set pgsm only true if all of them are within the P-GSM range?
how are we attempting to use a different format here? we return an error.
To view, visit change 27356. To unsubscribe, or for help writing mail filters, visit settings.