Attention is currently required from: laforge, pespin, keith.

View Change

5 comments:

• File src/input/e1d.c:

  • Patch Set #11, Line 340: osmo_fsm

    the question to me is if we really want to call this on every "short read", or just in case of ret < […]

    I think this makes sense (but I wonder what happens if we do not get a complete D_TSX_ALLOC_SIZE chunk. This means we would lose the incompletely read chunk?)

  • Patch Set #11, Line 391: osmo_fsm

    likewise here, a SOCK_STREAM socket might in theory do a successful write of any size, if the socket […]

    Done

  • Patch Set #11, Line 414: osmo_fsm

    same as above

    Done

  • Patch Set #11, Line 451: osmo_fsm

    here I think the existing implementation is OK, as a HDLC socket is an E1_TS_MODE_HDLCFCS socket, wh […]

    Yes, makes sense.

  • Patch Set #11, Line 476: osmo_fsm_inst_dispatch(g_e1d_fsm_inst, EV_CONN_LOST, line);

    I'm not sure about the exact semantics of SOCK_SEQPACKET here, but I would assume that a zero-length […]

    Yes, I think so too. (I have now changed the if above)

To view, visit change 32374. To unsubscribe, or for help writing mail filters, visit settings.