osmith submitted this change.

View Change

hlr: skip more tests for PyHSS

Skip more tests that don't make sense for PyHSS, and add comments
explaining why these tests are skipped.

Change-Id: If893ce854a1c0f873fa3d9544df0e23a7ed95525
---
M hlr/HLR_Tests.ttcn
1 file changed, 29 insertions(+), 9 deletions(-)

diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index c69efc3..6cfc08f 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -2203,14 +2203,9 @@
 	execute( TC_gsup_sai_err_invalid_imsi() );
 	execute( TC_gsup_sai() );
 	execute( TC_gsup_sai_num_auth_vectors() );
-	execute( TC_gsup_sai_eps() );
 	execute( TC_gsup_ul_unknown_imsi() );
-	execute( TC_gsup_ul_unknown_imsi_roaming_not_allowed() );
 	execute( TC_gsup_sai_err_unknown_imsi() );
 	execute( TC_gsup_ul() );
-	execute( TC_gsup_ul_subscriber_data() );
-	execute( TC_vty() );
-	execute( TC_vty_msisdn_isd() );
 	execute( TC_gsup_purge_cs() );
 	execute( TC_gsup_purge_ps() );
 	execute( TC_gsup_purge_unknown() );
@@ -2226,22 +2221,47 @@
 	/* "Structured" Supplementary Services */
 	execute( TC_mo_sss_reject() );
 
-	execute( TC_gsup_check_imei() );
-	execute( TC_gsup_check_imei_invalid_len() );
-	execute( TC_gsup_check_imei_unknown_imsi() );
-
 	/* Test features that are only implemented in OsmoHLR */
 	if (m_hlr_impl == HLR_IMPL_OSMOCOM) {
+		/* OsmoHLR's subscriber create on demand feature: store the
+		 * IMEI along with new subscribers in the HLR DB */
+		execute( TC_gsup_check_imei() );
+		execute( TC_gsup_check_imei_invalid_len() );
+		execute( TC_gsup_check_imei_unknown_imsi() );
+
+		/* OsmoHLR can be configured via VTY to send a different
+		 * UpdateLocation Error Cause for unknown subscribers, e.g.
+		 * ROAMING_NOTALLOWED (0x0d) instead of IMSI_UNKNOWN (0x02).
+		 * https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comments/ea58eb77_66cf8c82 */
+		execute( TC_gsup_ul_unknown_imsi_roaming_not_allowed() );
+
+		/* OsmoHLR can be used with osmo_dia2gsup in a 4G network. As
+		 * PyHSS supports diameter natively, it doesn't make sense to
+		 * run it with osmo_dia2gsup. */
+		execute( TC_gsup_sai_eps() );
+
+		/* OsmoHLR + osmo_dia2gsup: check for PDP Info IE in Send
+		 * Authentication Info Request (see SYS#6391 and
+		 * https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35899) */
+		execute( TC_gsup_ul_subscriber_data() );
+
+		/* OsmoHLR's VTY interface */
+		execute( TC_vty() );
+		execute( TC_vty_msisdn_isd() );
+
+		/* OsmoHLR's distributed GSM feature: Proxy tests */
 		execute( TC_gsup_ul_unknown_imsi_via_proxy() );
 		execute( TC_gsup_ul_via_proxy() );
 		execute( TC_mo_ussd_iuse_imsi_via_proxy() );
 		execute( TC_mo_ussd_iuse_msisdn_via_proxy() );
 		execute( TC_gsup_check_imei_via_proxy() );
 
+		/* OsmoHLR's subscriber create on demand feature */
 		execute( TC_subscr_create_on_demand_check_imei_early() );
 		execute( TC_subscr_create_on_demand_ul() );
 		execute( TC_subscr_create_on_demand_sai() );
 
+		/* OsmoHLR's distributed GSM feature: MS Lookup */
 		execute( TC_MSLookup_mDNS_service_other_home() );
 		execute( TC_MSLookup_GSUP_proxy() );
 		execute( TC_MSLookup_mDNS_service_GSUP_HLR_home() );

To view, visit change 41440. To unsubscribe, or for help writing mail filters, visit settings.