View Change

7 comments:

• File configure.ac:

  • Patch Set #2, Line 52: PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0)

    Please also make sure that both:

    • 'contrib/osmo-iuh.spec.in' and
    • debian/control

    are updated to reflect the new dependency.

• File src/hnbgw.c:

  • Patch Set #2, Line 376: LOGL_DEBUG

    Why debug? All other categories are set to LOGL_NOTICE.

  • Patch Set #2, Line 379:

    ws

• File src/hnbgw_cn.c:

  • Patch Set #2, Line 349: uint8_t *msg_data;

    const

  • Patch Set #2, Line 362: /* Intercept RAB Assignment Request, Setup MGW FSM */

    I am not saying the current approach is wrong, just an alternative variant:

      if (!map->is_ps && msgb_l2len(oph->msg) > 2) {
        switch (msgb_l2(oph->msg)[1]) {
        case RANAP_ProcedureCode_id_RAB_Assignment:
          return mgw_fsm_alloc_and_handle_rab_ass_req(map, oph);
        case RANAP_ProcedureCode_id_Iu_Release:
          /* Any IU Release will terminate the MGW FSM */
          mgw_fsm_handle_iu_release(map);
        }
      }

    IMO, it's shorter and easier to read.

• File src/hnbgw_rua.c:

  • Patch Set #2, Line 192: uint8_t *msg_data;

    const

• File src/mgw_fsm.c:

  • Patch Set #2, Line 189: switch (event) {

    weird formatting

To view, visit change 26725. To unsubscribe, or for help writing mail filters, visit settings.