Attention is currently required from: dexter, laforge.

View Change

4 comments:

• File pySim/euicc.py:

  • Patch Set #6, Line 580: -> bool:

    This function does not return a `bool`, but always `None` (implicit return) AFAICS.

  • Patch Set #6, Line 586: @staticmethod

    (just some ideas below, not blocking)

    Maybe use `@classmethod` instead, so that you can do:

    ```
    @classmethod
    def match_with_card(cls, scc: SimCardCommands) -> bool:
        return match_helper(scc, cls._match_with_card)
    ```

    Pros: no need to specify the class name and thus less risk of copy-paste errors.

    This method can then go to the parent class `CardProfileUICC` to avoid duplication.
    The `_match_with_card()` can then become an abstract static method.

  • Patch Set #6, Line 598: -> bool:

    likewise, change to `-> None`?

  • Patch Set #6, Line 616: -> bool:

    likewise, change to `-> None`?

To view, visit change 38049. To unsubscribe, or for help writing mail filters, visit settings.