View Change
1 comment:
Patchset:
Patch Set #3:
@pespin: can you explain why calling `osmo_fd_unregister()` after `close()` is wrong? AFAIU, because `osmo_stats_tcp_osmo_fd_unregister()` needs the actual `ofd-fd` but it might be sent to -1 already? If so, we may want to check `ofd->fd` and maybe print a warning?
To view, visit change 31804. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0754ac3110b63d2a380068010830af6c85b0a653
Gerrit-Change-Number: 31804
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Sun, 12 Mar 2023 12:08:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment