Attention is currently required from: neels, fixeria.

View Change

2 comments:

• File include/osmocom/bsc/bsc_msc_data.h:

  • Patch Set #1, Line 140: struct gsm_audio_support audio_support[16];

    No, i write "Let's just make it:" ... […]

    Well my point is that if there's only up to 13, I don't see why we want to lose memory there declaring an array of 16, which on top may confuse readers as per why it's 16 (as it happened to me) :)

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #1, Line 2729: int

    no, the compiler complained that it is 'long unsigned int' -- but my guess is that it's architecture […]

    IUUC that's precisely because it's a size_t, which under some architectures is a unsigned long and on others may be another type? If you use %zu you shouldn't face any problems I think.

To view, visit change 31609. To unsubscribe, or for help writing mail filters, visit settings.