pespin has uploaded this change for review.

View Change

lapdm: Take talloc msgb ownsership when enqueueing it

Otherwise the msg talloc rererence is kept parented at some unknown
pointer in some unknown upper layer.

Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7
Related: OS#6728
---
M src/gsm/lapdm.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/39808/1

diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c
index 61ea535..8f7db90 100644
--- a/src/gsm/lapdm.c
+++ b/src/gsm/lapdm.c
@@ -376,6 +376,8 @@
 		*msgb_push(msg, 1) = pad;
 		*msgb_push(msg, 1) = link_id;
 		*msgb_push(msg, 1) = chan_nr;
+		/* Take ownsership of msg, since we are keeping it around in this layer: */
+		talloc_steal(tall_lapd_ctx, msg);
 		msgb_enqueue(&dl->dl.tx_queue, msg);
 		return 0;
 	}
@@ -403,6 +405,8 @@
 		*msgb_push(msg, 1) = pad;
 		*msgb_push(msg, 1) = link_id;
 		*msgb_push(msg, 1) = chan_nr;
+		/* Take ownsership of msg, since we are keeping it around in this layer: */
+		talloc_steal(tall_lapd_ctx, msg);
 		msgb_enqueue(&dl->tx_ui_queue, msg);
 		return 0;
 	}

To view, visit change 39808. To unsubscribe, or for help writing mail filters, visit settings.