Attention is currently required from: neels, pespin.

View Change

3 comments:

• File src/osmo-upf/up_endpoint.c:

  • Patch Set #1, Line 176: OSMO_ASSERT(f_seid)

    missing semicolon?

  • Patch Set #1, Line 217: nack_response

    I would go for a separate function (e.g. `up_ep_tx_nack()`) to avoid code duplication.

• File src/osmo-upf/up_session.c:

  • Patch Set #1, Line 115: return NULL;

    This code is unreachable. Maybe do `OSMO_ASSERT(0)` here and remove these two above?

To view, visit change 41482. To unsubscribe, or for help writing mail filters, visit settings.