Attention is currently required from: osmith, Hoernchen, neels, laforge, fixeria, daniel.
6 comments:
File include/osmocom/core/osmo_io.h:
Patch Set #5, Line 57: int osmo_iofd_sendto_msgb(struct osmo_io_fd *iofd, struct msgb *msg, int flags,
maybe name it sendto_flags to clarify what are the flags for, but not that important.
File src/core/osmo_io.c:
Patch Set #5, Line 210: * If there are bytes left over *pending_out will point to a msgb with the remaining data.
" If there are bytes left over, *pending_out will" (see extra comma)
Patch Set #5, Line 426: if (!osmo_iofd_ops.close || (osmo_iofd_ops.close && osmo_iofd_ops.close(iofd)))
There seems to be a lot of expected stuff happening here with regards to struct configuration and return codes from function pointers.
I think this deserves a comment here explaining the expected lifecycle.
File src/osmo_io_poll.c:
Patch Set #3, Line 71: rc = write(ofd->fd, msgb_data(msg), msgb_length(msg));
the normal "read/write" case might be worth a dedicated function as we don't need a serialized msghe […]
read/write is basically recv/send with flags=0, so there's no need to have read/write imho.
maybe still look into this before merging it?
Ack
same as above
Ack
To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.