Attention is currently required from: Hoernchen, pespin.
21 comments:
File Transceiver52M/ms/ms_upper.h:
ws
Patch Set #3, Line 36: trx_if
do you really need/use TRXC/TRXD here?
File Transceiver52M/ms/ms_upper.cpp:
Patch Set #3, Line 61: #include <osmocom/core/gsmtap_util.h>
you're not using GSMTAP API here...
Patch Set #3, Line 64: // #include <osmocom/core/application.h>
removeme
Patch Set #3, Line 71: trx_if
do you really need/use TRXC/TRXD here?
Patch Set #3, Line 74: #include <osmocom/bb/l1sched/l1sched.h>
I don't see any l1sched_* API used in this file.
Patch Set #3, Line 177: return trash
can you clarify this a bit further? thrash?
Patch Set #3, Line 184: RSSI = 10
why 10?
Patch Set #3, Line 223: timingOffset = (int)round(0);
TODO/FIXME?
Patch Set #3, Line 238: trx_data_rx_handler
removeme
Patch Set #3, Line 246: trxcon_phyif_handle_clock_ind
removeme
Patch Set #3, Line 304: case trxcon::TRXCON_PHYIF_CMDT_RESET
Better use value-string for that. Ideally such a value string should be part of libtrxcon, so it's always in sync with the TRXCON_PHYIF_CMDT_* values.
Patch Set #3, Line 352: set_ta
Shouldn't this be done on receipt of TRXCON_PHYIF_CMDT_RESET instead?
Patch Set #3, Line 357: dbm = -80
please add a FIXME or TODO, so it's clear that the measurement logic is missing
Patch Set #3, Line 364: gsm_arfcn2freq10
careful, this function may return 0xffff
Patch Set #3, Line 385: assert
OSMO_ASSERT?
Patch Set #3, Line 425: trxcon
it's not trxcon app anymore
pass 0 to avoid confusion, we're not using fn_advance here
Patch Set #3, Line 430: gsmtap = 0;
gsmtap is a pointer, so = NULL
Patch Set #3, Line 431: 0x1234
What's this? Why not NULL?
I would avoid using 'trxc' here to avoid confusion with the TRXC protocol.
To view, visit change 30416. To unsubscribe, or for help writing mail filters, visit settings.