Attention is currently required from: pespin, keith, msuraev.
View Change
1 comment:
Patchset:
Patch Set #4:
I agree with pespin, it's dangerous to introduce a llist_count in a macro that inevitably somebody sooner or later will call also for DEBUG or INFO situations, as it's one of the usual macros that we tend to have for logging something with context.
You can introduce a global counter and inc/dec it at every llist_add/del to avoid that, or you could print the counter only if LVL >= NOTICE or something?
To view, visit change 29752. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Idfab1f4be034fc8eab8f87bd8cd88723939e107e
Gerrit-Change-Number: 29752
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith@rhizomatica.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: keith <keith@rhizomatica.org>
Gerrit-Attention: msuraev <msuraev@sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Oct 2022 16:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment