Attention is currently required from: dexter, laforge.
1 comment:
File pySim/esim/saip/__init__.py:
Patch Set #3, Line 369: if self.rec_len and not fd_dec['num_of_rec']:
To me this looks equivalent. […]
The difference is a file that comes from a template: File.__init__ calls from_template() before from_fileDescriptor(), and from_template() copies the template's nb_rec, so nb_rec is no longer None when the descriptor is decoded. For such a file with a fileDescriptor that has a record length but no count, and a larger efFileSize, the old check kept the template's count. In the repro, EF.MSISDN (template: 1 record) with record length 34 and efFileSize 68 decodes as 1 record of 34 bytes before and 2 records, 68 bytes, with the patch. Without a template you're right, both behave the same. Should the comment say that from_template() has set nb_rec already?
To view, visit change 43984. To unsubscribe, or for help writing mail filters, visit settings.