Attention is currently required from: pespin, fixeria.

View Change

1 comment:

• File src/host/layer23/src/modem/rlcmac.c:

  • Patch Set #1, Line 173: rlcmac_prim_l1ctl_alloc

    @pespin: I would like to be able to allocate RLCMAC_L1CTL primitives like this, instead of using functions like osmo_gprs_rlcmac_prim_alloc_l1ctl_pdch_data_ind(). One problem is that it's quite a long symbol name, which alone takes almost the entire line on my screen, so passing it several arguments would make it completely unreadable. The benefits of letting the user fill-in the prim structure are:

    • readability, as I already said above;
    • extensibility: once we add more fields, there would be no need to add `osmo_gprs_rlcmac_prim_alloc_l1ctl_pdch_data_ind{1,2,3,...}()`;
    • consistency with other osmo-API, like the L1SAP code.

    Would it be possible to expose `[osmo_gprs_]rlcmac_prim_l1ctl_alloc()`?

To view, visit change 31572. To unsubscribe, or for help writing mail filters, visit settings.